[release-1.11] 🐛Verify providers need upgrade before applying #12768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user runs `upgrade plan` and the results show there are no available upgrades, the expectation is they then do not attempt to apply the plan. But nothing prevents them from doing so. If a non-upgrade plan is applied, the current apply logic does not handle the case where the "next version" is empty. To make this more robust, and to protect against users trying to apply plans with no available upgrades, this performs a quick validation on the plan providers to make sure they have a version to upgrade to. If not, the `upgrade apply` call ends up being a no-op and avoids potentially confusing error output. Signed-off-by: Sean McGinnis <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Member
|
/area clusterctl |
k8s-ci-robot
added
area/clusterctl
Contributor
|
LGTM label has been added. Git tree hash: 0a864b4798841694eff1de7d9ce8263ddea52c01
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #12753
/assign sbueringer