Skip to content

Conversation

@peppi-lotta
Copy link
Contributor

What this PR does / why we need it:
🌱 clusterctl: add metal3 ipam provider

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2025
@peppi-lotta
Copy link
Contributor Author

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Sep 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @peppi-lotta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/clusterctl Issues or PRs related to clusterctl and removed do-not-merge/needs-area PR is missing an area label labels Sep 11, 2025
@sbueringer
Copy link
Member

Thank you!

/ok-to-test
/lgtm
/approve

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

Thank you!

/ok-to-test
/lgtm
/approve

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 46c1b3ce98b2d7cfd37e115affe1a5392382b117

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@sbueringer
Copy link
Member

/hold
Needs a small test fix

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-IPAMProvider-Metal3 branch from 9b3a994 to 8fad461 Compare September 12, 2025 06:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-IPAMProvider-Metal3 branch from 8fad461 to 8895670 Compare September 12, 2025 07:55
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-IPAMProvider-Metal3 branch from 8895670 to c42f7b3 Compare September 12, 2025 08:13
@peppi-lotta
Copy link
Contributor Author

peppi-lotta commented Sep 12, 2025

@sbueringer I had missed some of the test related changes. Those are now added :)

@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ff0d5121eb9fd1843157def0dabf6eaf5b8bde7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/cherr-pick release-1.11

@k8s-ci-robot k8s-ci-robot merged commit 0a4ba47 into kubernetes-sigs:main Sep 12, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 12, 2025
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #12760

In response to this:

Thank you!

/ok-to-test
/lgtm
/approve

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants