-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Add Metal3 as an IPAMProvider #12756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add Metal3 as an IPAMProvider #12756
Conversation
|
/area clusterctl |
|
Hi @peppi-lotta. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you! /ok-to-test /cherry-pick release-1.11 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM label has been added. Git tree hash: 46c1b3ce98b2d7cfd37e115affe1a5392382b117
|
|
/hold |
9b3a994 to
8fad461
Compare
8fad461 to
8895670
Compare
Signed-off-by: peppi-lotta <[email protected]>
8895670 to
c42f7b3
Compare
|
@sbueringer I had missed some of the test related changes. Those are now added :) |
|
Thank you! /lgtm |
|
LGTM label has been added. Git tree hash: 0ff0d5121eb9fd1843157def0dabf6eaf5b8bde7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherr-pick release-1.11 |
|
@sbueringer: new pull request created: #12760 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
🌱 clusterctl: add metal3 ipam provider
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #