✨Add inplace updates featuregate #12755
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a800e75e1593bfac271a1005c1042e88b09a26da
|
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
inplaceupdatesfeaturegate
branch
from
4741dbd to
b5f0930
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/S
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: ec2cb08ff484b5a915f369b559223684888e0963
|
k8s-ci-robot
added
the
approved
| - "--diagnostics-address=${CAPI_DIAGNOSTICS_ADDRESS:=:8443}" | ||
| - "--insecure-diagnostics=${CAPI_INSECURE_DIAGNOSTICS:=false}" | ||
| - "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=true},KubeadmBootstrapFormatIgnition=${EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION:=false},PriorityQueue=${EXP_PRIORITY_QUEUE:=false}" | ||
| - "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=true},KubeadmBootstrapFormatIgnition=${EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION:=false},PriorityQueue=${EXP_PRIORITY_QUEUE:=false},InPlaceUpdates=${EXP_IN_PLACE_UPDATES:=false}" |
There was a problem hiding this comment.
updates and upgrades are not the same topic. was this discussed on the CAEP?
if this feature gate covers installing new versions of kubernetes or a Linux kernel and OS packages maybe it should be InPlaceUpgrades.
update, implies changing a value and making smaller changes, such as updating a machine configuration.
There was a problem hiding this comment.
In CAPI we usually use upgrade to refer to Kubernetes version bumps, while updates are all sort of rollouts (including Kubernetes version bumps)
With that in mind, choosing updates was intentional
| - "--diagnostics-address=${CAPI_DIAGNOSTICS_ADDRESS:=:8443}" | ||
| - "--insecure-diagnostics=${CAPI_INSECURE_DIAGNOSTICS:=false}" | ||
| - "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=true},KubeadmBootstrapFormatIgnition=${EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION:=false},PriorityQueue=${EXP_PRIORITY_QUEUE:=false}" | ||
| - "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=true},KubeadmBootstrapFormatIgnition=${EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION:=false},PriorityQueue=${EXP_PRIORITY_QUEUE:=false},InPlaceUpdates=${EXP_IN_PLACE_UPDATES:=false}" |
There was a problem hiding this comment.
@alexander-demicev Just fyi, this was the wrong manager.yaml. Should have been KCP not CABPK
(just noticed when implementing a prototype)
5 participants
What this PR does / why we need it:
This PR adds inplace updates featuregate
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Tracking issue #12291
/area misc