Skip to content

✨ Ensure ExtensionConfig controller can be used outside of the core provider #12754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Sep 12, 2025
Merged

✨ Ensure ExtensionConfig controller can be used outside of the core provider #12754

k8s-ci-robot merged 1 commit into from
Sep 12, 2025

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 11, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #12291

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2025
@sbueringer sbueringer mentioned this pull request Sep 11, 2025
Open
80 tasks
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 11, 2025
@sbueringer sbueringer added the area/runtime-sdk Issues or PRs related to Runtime SDK label Sep 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Sep 11, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Sep 11, 2025

/test pull-cluster-api-e2e-main

@sbueringer sbueringer force-pushed the pr-extensionconfig-refactor branch from c9031d9 to d76dc9d Compare September 11, 2025 10:11
@sbueringer
Copy link
Member Author

sbueringer commented Sep 11, 2025

/test pull-cluster-api-e2e-main

alexander-demicev
alexander-demicev reviewed Sep 11, 2025
View reviewed changes
controlplane/kubeadm/main.go
Client: mgr.GetClient(),
APIReader: mgr.GetAPIReader(),
RuntimeClient: runtimeClient,
ReadOnly: true,
Copy link
Contributor

@alexander-demicev alexander-demicev Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to have a way to prevent multiple instances of ExtensionConfig reconciler with write permissions to be created?

Copy link
Member Author

@sbueringer sbueringer Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how we can do this considering that these are separate binaries
(so I'm okay with the current state)

@sbueringer sbueringer force-pushed the pr-extensionconfig-refactor branch from d76dc9d to 8bb27be Compare September 11, 2025 14:48
@sbueringer
Copy link
Member Author

sbueringer commented Sep 11, 2025

Rebased to already use the new feature gate

@sbueringer
Copy link
Member Author

sbueringer commented Sep 11, 2025

/test pull-cluster-api-e2e-main

@alexander-demicev
Copy link
Contributor

alexander-demicev commented Sep 12, 2025

/lgtm

@alexander-demicev
Copy link
Contributor

alexander-demicev commented Sep 12, 2025

thanks a lot for the change!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 12, 2025

LGTM label has been added.

Git tree hash: e8c8b6f765e056d7fc0d0c8c35a2fdcef15a0a31

fabriziopandini
fabriziopandini reviewed Sep 12, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@sbueringer sbueringer force-pushed the pr-extensionconfig-refactor branch from 8bb27be to f682e53 Compare September 12, 2025 10:21
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 12, 2025

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main f682e53 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

fabriziopandini
fabriziopandini reviewed Sep 12, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 12, 2025

LGTM label has been added.

Git tree hash: ce547df54f9ceb48a1a340819d5954eba1fca2c0

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 987c157 into kubernetes-sigs:main Sep 12, 2025
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 12, 2025
@sbueringer sbueringer deleted the pr-extensionconfig-refactor branch September 12, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@g-gaston g-gaston Awaiting requested review from g-gaston

@sivchari sivchari Awaiting requested review from sivchari

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

Assignees

@fabriziopandini fabriziopandini

@alexander-demicev alexander-demicev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

4 participants

@sbueringer @alexander-demicev @k8s-ci-robot @fabriziopandini