-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 Fix flaky TestReconcileState unit test #12617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix flaky TestReconcileState unit test #12617
Conversation
Signed-off-by: Stefan Büringer [email protected]
|
/cherry-pick release-1.11 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @JoelSpeed @mboersma @sivchari |
|
/approve |
|
LGTM label has been added. Git tree hash: 38f9a0359f0d6ac94ebc34d54dd594d3e2538e2e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sbueringer: new pull request created: #12633 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This should fix: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-test-mink8s-main/1953071454073393152
ClusterClasses cannot be deleted when they are still used. So we should first delete the Cluster, wait until the client observes the Cluster deletion and then delete the ClusterClass in our tests
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #