🐛 Fix autoscaler e2e test flake

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
We recently started running the autoscaler test with ScaleToAndFromZero: true. Since then there were a few flakes like this: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-e2e-mink8s-main/1954475054460833792

I think the problem is:

• In l.282: "Checking the MachineDeployment finished scaling up" the MD has 1 replica, but the corresponding Node is not up yet
• Because of that the Deployment in l.315: "Creating workload that forces the system to scale up" is created with 2 replicas instead of 3 replicas (AddScaleUpDeploymentAndWait uses count(Nodes) + 1 as replicas)
• The test then fails later because we don't have enough Pods

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/test pull-cluster-api-e2e-main

[sbueringer]

/test pull-cluster-api-e2e-main

[sbueringer]

/test pull-cluster-api-e2e-main

Unrelated flake

[sbueringer]

/assign @JoelSpeed @elmiko @mboersma @sivchari

[sbueringer]

/assign @chrischdi

[neolit123]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 499fb2d03310c160a9b91d523e2debb8d3fb5582

[elmiko]

i'm not overly familiar with the framework changes, but this makes sense to me.

/lgtm

[sbueringer]

/approve

Given lgtm's above

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/cherry-pick release-1.11

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #12627

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.