🌱 Add quickstart e2e test with v1beta1 with ClusterClass and RuntimeSDK #12577
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
size/L
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-v1beta1-test
branch
from
9fa9671 to
fdd0836
Compare
sbueringer
changed the title
|
/assign @chrischdi @sivchari |
| @@ -0,0 +1,44 @@ | |||
| apiVersion: cluster.x-k8s.io/v1beta1 | |||
There was a problem hiding this comment.
This is a v1beta1 version of test/e2e/data/infrastructure-docker/main/cluster-template-upgrades-runtimesdk/cluster-runtimesdk.yaml
There was a problem hiding this comment.
Should we add this as a comment in the file at the top? (same for the other yamls we create in this PR)
There was a problem hiding this comment.
Good idea, thx, done!
| @@ -0,0 +1,152 @@ | |||
| apiVersion: cluster.x-k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Basically identical (apart from the name) to the release-1.10 version of test/e2e/data/infrastructure-docker/main/clusterclass-quick-start-runtimesdk.yaml
(also a v1beta1 version of test/e2e/data/infrastructure-docker/main/clusterclass-quick-start-runtimesdk.yaml)
| generatePatchesExtension: generate-patches.${EXTENSION_CONFIG_NAME:-"k8s-upgrade-with-runtimesdk"} | ||
| validateTopologyExtension: validate-topology.${EXTENSION_CONFIG_NAME:-"k8s-upgrade-with-runtimesdk"} | ||
| discoverVariablesExtension: discover-variables.${EXTENSION_CONFIG_NAME:-"k8s-upgrade-with-runtimesdk"} | ||
| generatePatchesExtension: generate-patches.${EXTENSION_CONFIG_NAME:-k8s-upgrade-with-runtimesdk} |
There was a problem hiding this comment.
The quotes would be there after envsubst, this never worked.. (we just never relied on the default values)
| // which unblocks CNI installation, and for the control plane machines to be ready (after CNI installation). | ||
| ControlPlaneWaiters clusterctl.ControlPlaneWaiters | ||
|
|
||
| // ExtensionConfigName is the name of the ExtensionConfig. Defaults to "quick-start". |
There was a problem hiding this comment.
The additions in this file are mostly copied from scale.go and are only there to deploy the ExtensionConfig if RuntimeSDK is used
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 5dcd1a40333d6662760f71751345e21bf325eabc |
|
/test pull-cluster-api-e2e-main Just to check if it's stable |
|
/test pull-cluster-api-e2e-main |
1 similar comment
|
/test pull-cluster-api-e2e-main |
|
Looks pretty stable |
k8s-ci-robot
removed
the
lgtm
sbueringer
added
the
lgtm
sbueringer
added
the
tide/merge-method-squash
|
New changes are detected. LGTM label has been removed. |
|
/test pull-cluster-api-e2e-main |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.11 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sbueringer: new pull request created: #12590 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11947