Skip to content

✨Propagate the deletion related timeout from MD to old MS when old MS is getting deleted #12144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lubronzhan wants to merge 1 commit into from
Closed

✨Propagate the deletion related timeout from MD to old MS when old MS is getting deleted #12144

lubronzhan wants to merge 1 commit into from

Conversation

@lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented May 2, 2025

What this PR does / why we need it:
Fix case 3 in #10753

The following happens:
Someone updates the MD (e.g. bump the Kubernetes version)
MD creates a new MS and scales it up
In parallel MD scales down the old MS to 0
=> In this scenario today the MD controller does not propagate the timeouts from MD to all MS (only to the new/current one, not to the old ones). So the Machines of the old MS won't get new timeouts set in the MD

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes ##10753

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label May 2, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 2, 2025
@lubronzhan
Copy link
Contributor Author

lubronzhan commented May 2, 2025

/area machine

@k8s-ci-robot k8s-ci-robot added area/machine Issues or PRs related to machine lifecycle management and removed do-not-merge/needs-area PR is missing an area label labels May 2, 2025
sivchari
sivchari reviewed May 3, 2025
View reviewed changes
sivchari
sivchari reviewed May 4, 2025
View reviewed changes
Copy link
Member

@sivchari sivchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry additional one nits. Otherwise LGTM

@lubronzhan lubronzhan force-pushed the topic/lubron/fix-10753 branch from ecc96d3 to 48b83c1 Compare May 4, 2025 20:18
@lubronzhan @sivchari
Propagate the deletion related timeout from MD to old MS when old MS …
2a4ac40 
…is getting deleted

Signed-off-by: Lubron Zhan <[email protected]>

Co-authored-by: sivchari <[email protected]>
@lubronzhan lubronzhan force-pushed the topic/lubron/fix-10753 branch from 48b83c1 to 2a4ac40 Compare May 4, 2025 20:31
@sivchari
Copy link
Member

sivchari commented May 5, 2025

/lgtm

/cc @fabriziopandini @chrischdi

@k8s-ci-robot k8s-ci-robot requested a review from chrischdi May 5, 2025 02:29
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 5, 2025

LGTM label has been added.

DetailsGit tree hash: f711da8b4d7b4386a9519d3105d95960483ae1ba

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 16, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2025
@sbueringer
Copy link
Member

sbueringer commented Sep 29, 2025

Sorry didn't get around to reviewing this sooner. We're now doing some bigger refactorings to the MD controller for in-place updates. Let's try to revisit this change once the refactorings are done (either towards the end of this release cycle or early in the next one)

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 7, 2025

This will be fixed by the refactoring we are doing within the context of #12291

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 9, 2025

/close in favour of #12841

@sbueringer sbueringer closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@chrischdi chrischdi Awaiting requested review from chrischdi

1 more reviewer

@sivchari sivchari sivchari left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sivchari sivchari

Labels

area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lubronzhan @k8s-ci-robot @sivchari @sbueringer @fabriziopandini