📖 Refactor ControlPlane contract #11285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/documentation
k8s-ci-robot
added
the
size/XXL
59 tasks
vincepri
approved these changes
Oct 15, 2024
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: d5105db2b8efe71f44e4a9dd350e1ffa76f28941 |
Member
|
/assign |
sbueringer
reviewed
Oct 15, 2024
fabriziopandini
force-pushed
the
refactor-control-plane-contract
branch
from
71d3ecb to
5792866
Compare
k8s-ci-robot
removed
the
lgtm
sbueringer
reviewed
Oct 17, 2024
Member
sbueringer
left a comment
sbueringer
left a comment
There was a problem hiding this comment.
Last nit, feel free to squash directly
fabriziopandini
force-pushed
the
refactor-control-plane-contract
branch
from
5792866 to
6fc73d9
Compare
Member
|
/lgtm Thank you! Nice work on the contracts. Really a huge improvement |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: d923f3dd05958a1105a998a4161b0919380d35e1 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactor the ControlPlane contract. Most notably
/area documentation
Part of #11105