🌱 Use errors package of Go

[sivchari]

What this PR does / why we need it:

Go has errors package to use Is() and As(). These API can check recursively if the err is one we want.
So I use errors package to check recursively.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[neolit123]

generally seems better to use Is() and As() instead of the type assertions.

[sivchari]

/assign

[sbueringer]

I currently don't find the time to review this PR. Just one comment, we have to be really really sure this doesn't break anything accidentally (by catching more or less errors than before)

[anmazzotti]

Agree with @neolit123 a few instances could use errors.Is instead, but this is also ok.

[sbueringer]

Let's use errors.As only if we actually want to use the error afterwards. In a lot of cases we only check but never use the error value

[sivchari]

I rebased and fixed some review points. Thanks.

[sivchari]

The list that I should write UnitTests

• handleGithubErr
• (g *gitHubRepository) getVersions
• (g *gitHubRepository) handleGithubErr
• (r *KubeadmControlPlaneReconciler) Reconcile

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[neolit123]

as i commented here, kubeadm wrapped the stdlib errors package to resemble pkg/errors in a consistent manner.

#6688 (comment)

that i think is the better solution instead of importing the stdlib errors and using fmt.Errorf in some places.

capi can fork the relevant bits from kubeadm. maybe we can put this code in k/component-base eventually but that needs agreement with other sigs.

[sivchari]

It sounds good, then if we decide to use it, we might be able to drop the direct dependence of pkg/errors completely.

[sbueringer]

Can we please stick with using pkg/errors for this PR?

We can have the discussion on how to migrate and then make this a dedicated effort, but it should not be mixed with other changes in my opinion.

(For what it's worth, I agree with Lubomir's suggestion on how to migrate)

[sbueringer]

Thx!

/lgtm
/approve
/test pull-cluster-api-e2e-main

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2f3a32316c42371c579f7a6cece3686d37c59a49

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Will be fixed elsewhere

/override pull-cluster-api-e2e-main

[k8s-ci-robot]

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

Will be fixed elsewhere

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.