Skip to content

Conversation

@damdo
Copy link
Member

@damdo damdo commented May 24, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
📖 Add documentation for nightly builds

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2024
@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims May 24, 2024 10:14
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 24, 2024
@netlify
Copy link

netlify bot commented May 24, 2024

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 4aabc4a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/665441ea7961aa00084af162
😎 Deploy Preview https://deploy-preview-1243--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@damdo
Copy link
Member Author

damdo commented May 24, 2024

/assign @richardcase

@damdo damdo changed the title Add documentation for nightly builds Add documentation for nightly build May 25, 2024
@damdo damdo changed the title Add documentation for nightly build Add documentation for nightly builds May 25, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

just need to fix the misspell

@damdo damdo force-pushed the add-documentation-for-nightly-builds branch from 634ce21 to 4aabc4a Compare May 27, 2024 08:18
@damdo
Copy link
Member Author

damdo commented May 27, 2024

@cpanato Misspell is not from this PR, but was fixed by: #1233 when it merged.
I just rebased on top of main so it resolved now.
Could you re LGTM/approve? Thanks!

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6cc9af0 into kubernetes-sigs:main May 27, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants