Pass required RangeName to compute.SubnetworkSecondaryRange

[brandonbell]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
fixes #1058

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Fix a bug to support `secondyCidrBlocks`.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: brandonbell / name: Brandon Bell (9dce475)

[k8s-ci-robot]

Welcome @brandonbell!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @brandonbell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

/ok-to-test

[richardcase]

Thanks for this @brandonbell 🙇 Do you have a copy of the error thats reported? It would be good to capture that in an issue that we can link to this PR....so for anyone searching on the same error they will see there is an issue/pr already.

[brandonbell]

@richardcase I opened #1058 and noted it in the PR comments. Thanks!

[richardcase]

/test ?

[k8s-ci-robot]

@richardcase: The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-gcp-build
• /test pull-cluster-api-provider-gcp-e2e-test
• /test pull-cluster-api-provider-gcp-make
• /test pull-cluster-api-provider-gcp-test
• /test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-gcp-apidiff
• /test pull-cluster-api-provider-gcp-capi-e2e
• /test pull-cluster-api-provider-gcp-conformance
• /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
• /test pull-cluster-api-provider-gcp-coverage
• /test pull-cluster-api-provider-gcp-coverage-release-1-4
• /test pull-cluster-api-provider-gcp-coverage-release-1-5
• /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-gcp-apidiff
• pull-cluster-api-provider-gcp-build
• pull-cluster-api-provider-gcp-e2e-test
• pull-cluster-api-provider-gcp-make
• pull-cluster-api-provider-gcp-test
• pull-cluster-api-provider-gcp-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

@brandonbell - would you be able to share any testing that you have done with this?

[richardcase]

/lgtm

Will approve after discussion on testing.

[brandonbell]

/test all

[brandonbell]

would you be able to share any testing that you have done with this?

Absolutely. Creating the GCPCluster type with:

    subnets:
    - name: gce-test1
      cidrBlock: 10.250.0.0/18
      secondaryCidrBlocks: 
        pods: 10.250.128.0/17
        services: 10.250.64.0/18

fails per the googleapi: Error 400: Required field 'resource.secondaryIpRanges[0].rangeName' not specified error from the controller. Updating the image to brandonbell/cluster-api-gcp-controller:arm64 (Dockerhub) built from the branch successfully creates the secondary ranges matching the name/range.

[richardcase]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brandonbell, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment