Skip to content

Conversation

@chuckha
Copy link
Contributor

@chuckha chuckha commented Aug 10, 2018

ref #5

Signed-off-by: Chuck Ha [email protected]

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2018
@chuckha
Copy link
Contributor Author

chuckha commented Aug 13, 2018

/assign @roberthbailey

@roberthbailey
Copy link

You should assign to someone in cluster-api-aws-maintainers (https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/OWNERS_ALIASES#L30).

@roberthbailey
Copy link

/unassign @roberthbailey

@chuckha
Copy link
Contributor Author

chuckha commented Aug 13, 2018

ah, gotcha, sorry about that!

/assign @detiber

@detiber
Copy link
Contributor

detiber commented Aug 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit eb36e31 into kubernetes-sigs:master Aug 13, 2018
enxebre pushed a commit to enxebre/cluster-api-provider-aws-2 that referenced this pull request Sep 28, 2018
chrischdi added a commit to chrischdi/cluster-api-provider-aws that referenced this pull request Nov 20, 2025
k8s-ci-robot pushed a commit that referenced this pull request Nov 21, 2025
* deps: upgrade Kubernetes dependencies to v0.33.4

- Update core Kubernetes dependencies from v0.32.3 to v0.33.4:
  - k8s.io/api, k8s.io/apimachinery, k8s.io/client-go
  - k8s.io/apiserver, k8s.io/cli-runtime, k8s.io/kubectl
  - k8s.io/apiextensions-apiserver, k8s.io/component-base
- Upgrade prometheus/client_golang from v1.19.1 to v1.22.0
- Update cel.dev/expr from v0.18.0 to v0.19.1
- Upgrade google/cel-go from v0.22.0 to v0.23.2
- Update golang.org/x/time from v0.8.0 to v0.9.0
- Upgrade gRPC from v1.67.3 to v1.68.1
- Update OpenTelemetry packages to v1.33.0
- Refresh k8s.io/utils and other indirect dependencies
- Update kube-openapi and structured-merge-diff versions

* deps: update cluster-api to v1.11.1 and controller-runtime to v0.21.0

- Upgrade cluster-api from v1.10.2 to v1.11.1
- Upgrade controller-runtime from v0.20.4 to v0.21.0
- Update various golang.org/x/* packages
- Update testing dependencies (ginkgo, gomega)
- Update OpenTelemetry and other indirect dependencies

* WIP no IDE errors

* WIP IDE Errors

* Fix go dependencies

Signed-off-by: Borja Clemente <[email protected]>

* Update imports, code and generations to CAPI 1.11

- Update all imports to v1beta2 types except for conditions staying in
  v1beta1.
- Adapt source code to work with v1beta2 and deprecated conditions.
- Manually update conversions.

Signed-off-by: Borja Clemente <[email protected]>

* Update linting pkg alias and fix broken imports blocks

Signed-off-by: Borja Clemente <[email protected]>

* Remove unnecessary Paused constants

Signed-off-by: Borja Clemente <[email protected]>

* Fix import aliases

Signed-off-by: Borja Clemente <[email protected]>

* Fix broken imports

Signed-off-by: Borja Clemente <[email protected]>

* Revert public APIS back to v1beta1 while internally using v1beta2

Introducing v1beta2 on public types is a breaking change so they have to
stay in v1beta1. Internally though, migration to v1beta2 is happening
(except for conditions).

Signed-off-by: Borja Clemente <[email protected]>

* Revert infrav1 conditions to v1beta1 and consolidate imports

Signed-off-by: Borja Clemente <[email protected]>

* Consolidate conditions imports and fix linting

Signed-off-by: Borja Clemente <[email protected]>

* Fix regression in machine deployments without failure domain set

Signed-off-by: Borja Clemente <[email protected]>

* Revert missing public APIs to v1beta1

Signed-off-by: Borja Clemente <[email protected]>

* Consolidate infrav1beta1 imports into infrav1

Signed-off-by: Borja Clemente <[email protected]>

* Remove unused conditions constants

Signed-off-by: Borja Clemente <[email protected]>

* Fix setting wrong condition type

Signed-off-by: Borja Clemente <[email protected]>

* Cast v1beta1 conditions instead of creating a new constant

Signed-off-by: Borja Clemente <[email protected]>

* Revert changed public APIs and adapt internally to v1beta2

Signed-off-by: Borja Clemente <[email protected]>

* Resolve conflicts with main

Signed-off-by: Borja Clemente <[email protected]>

* Add deprecated CAPI imports linter rule

Add rule to allow using deprecated v1beta1 CAPI APIs and removed linter
comments everywhere.

Signed-off-by: Borja Clemente <[email protected]>

* Apply review corrections

Signed-off-by: Borja Clemente <[email protected]>

* Adjust e2e and metadata versions

Signed-off-by: Borja Clemente <[email protected]>

* Apply review feedback on awscluster_webhook

Signed-off-by: Borja Clemente <[email protected]>

* FIx unit tests

Signed-off-by: Borja Clemente <[email protected]>

* Review feedback

Signed-off-by: Borja Clemente <[email protected]>

* Apply review feedback

Signed-off-by: Borja Clemente <[email protected]>

* Add CRD RBAC to the awsmachine controller

Signed-off-by: Borja Clemente <[email protected]>

* e2e: add v1beta1 CAPI scheme to clients and adjust modifyFunc test to use the new field name

* Fix linting issues

Signed-off-by: Borja Clemente <[email protected]>

* Fix nodeDrainTimeoutSeconds field in clusterclass test

Signed-off-by: Borja Clemente <[email protected]>

* e2e: fix contract for CAPI

* fix path again

* e2e: fix contract for capa 9.99.99 (#3)

* e2e: use correct type for setting field (#4)

* rosa: deflake unit test (#5)

* rosa: deflake unit test

* fixup

* e2e: fix config metadata and contract version pinning (#6)

* e2e: fix config metadata file path

Signed-off-by: Borja Clemente <[email protected]>

* Bump KCP Template for clusterclass changes (#7)

---------

Signed-off-by: Borja Clemente <[email protected]>
Co-authored-by: Bryan Cox <[email protected]>
Co-authored-by: Christian Schlotter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants