Skip to content

Conversation

@justinmir
Copy link

/kind feature

What this PR does / why we need it:

This change adds support for specifying placement group configuration in AWSMachinePool launch templates.

New fields added to AWSLaunchTemplate:

  • PlacementGroupName: specifies the name of the placement group in which to launch instances
  • PlacementGroupPartition: specifies the partition number within a partition placement group (valid values: 1-7)

This enables users to target specific partitions when using partition placement groups with MachinePool resources, providing higher levels of availability by ensuring instances in different partitions do not share underlying hardware.

Which issue(s) this PR fixes
Relates-to: #4870

Special notes for your reviewer:
This change mirrors #4870 but for launch templates. This allows us to create ASGs that target a specific placement group partition.

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/placement-groups.html
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_Placement.html

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Adds support for specifying placement group configuration for AWSMachinePool launch templates.

This change adds support for specifying placement group configuration
in AWSMachinePool launch templates.

New fields added to AWSLaunchTemplate:
- PlacementGroupName: specifies the name of the placement group in
  which to launch instances
- PlacementGroupPartition: specifies the partition number within a
  partition placement group (valid values: 1-7)

This enables users to target specific partitions when using partition
placement groups with MachinePool resources, providing higher levels
of availability by ensuring instances in different partitions do not
share underlying hardware.

Relates-to: kubernetes-sigs#4870
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @justinmir!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @justinmir. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants