✨ Wait for AWSCluster dependent object to be deleted

[alexander-demicev]

What type of PR is this?
/kind feature

What this PR does / why we need it:

This PR adds a similar check

cluster-api-provider-aws/controlplane/eks/controllers/awsmanagedcontrolplane_controller.go

Line 394 in 4e912b4

numDependencies, err := r.dependencyCount(ctx, managedScope)

for AWSCluster. It ensures all machines are gone before proceeding with deletion.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5107

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Wait for AWSCluster dependent object to be deleted

[richardcase]

Thanks for this @alexander-demicev . Looks good to me. Lets check that the e2e still pass.

[richardcase]

/test ?

[k8s-ci-robot]

@richardcase: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[richardcase]

/test pull-cluster-api-provider-aws-e2e

[alexander-demicev]

/test pull-cluster-api-provider-aws-e2e

[damdo]

Looks good, left a couple of non-blocking nits on the log lines.
Thanks for fixing this @alexander-demicev

[damdo]

/lgtm

[damdo]

Thanks @alexander-demicev

/assign @richardcase @nrb

[nrb]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment