Handle endpoint not being rerturned in AzureCloudConfigFromURL

[theobarberbany]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This change updates AzureCloudConfigFromURL to check that the URL (ResourceManagerEndpoint) that is used to build the config has been returned. If it has not, it sets it using the URL provided.

This avoids the case where the endpoint is used to build config, but does not return it's self - causing the created configuration to fail .

Which issue(s) this PR fixes:

Fixes #5558

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

Hi @theobarberbany. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/ok-to-test

[MartinForReal]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MartinForReal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MartinForReal]

Thank you for the pr! nice catch! @theobarberbany