Skip to content

Conversation

@shuqz
Copy link
Collaborator

@shuqz shuqz commented Nov 18, 2025

Description

  • due to ALB limitation (cannot preserve suffix), we cannot support ReplacePrefixMatch in Filter type: RequestRedirect. we can still support ReplaceFullPath
  • added instruction in documentation
  • reconcile will error out if user try to use ReplacePrefixMatch, e.g
{"level":"error","ts":"2025-11-18T01:23:03Z","msg":"Reconciler error","controller":"gateway.k8s.aws/alb","object":{"name":"same-namespace","namespace":"gateway-conformance-infra"},"namespace":"gateway-conformance-infra","name":"same-namespace","reconcileID":"","error":"ReplacePrefixMatch is not supported in RequestRedirect filters. ALB redirect actions cannot preserve path suffixes during prefix replacement. Use URLRewrite filter with ReplacePrefixMatch for path transformations, or use ReplaceFullPath in RequestRedirect for static path redirects"}
  • modified e2e test too

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shuqz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants