Remove go deb / Gopkg.toml handling in verify-vendor.#306
Merged
Conversation
No kubernetes-csi repo uses this tool: https://github.com/search?q=org%3Akubernetes-csi+path%3A**%2FGopkg.toml&type=code The current go dep handling introduces a supply chain attack: * Create a pull request against the target repository. * Modify a vendored dependency in the vendor/ directory to include a malicious payload or backdoor. * Add an empty file named Gopkg.toml to the root of the repository. * Commit and push the changes. Observe that the CI verify-vendor.sh script outputs 'skipping check, dep >= 0.5 required' and exits with a success status, bypassing the go mod vendor checks. Go dep has been deprecated since 2020 (golang/go#38158). Removing this support will make future maintenance easier.
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current go dep handling introduces a supply chain attack:
Create a pull request against the target repository.
Modify a vendored dependency in the vendor/ directory to include a malicious payload or backdoor.
Add an empty file named Gopkg.toml to the root of the repository.
Commit and push the changes. Observe that the CI verify-vendor.sh script outputs 'skipping check, dep >= 0.5 required' and exits with a success status, bypassing the go mod vendor checks.
No kubernetes-csi repo uses this tool: https://github.com/search?q=org%3Akubernetes-csi+path%3A**%2FGopkg.toml&type=code
Go dep has been deprecated since 2020
(golang/go#38158). Removing this support will make future maintenance easier.