Skip to content

fixed broken links of testgrid dashboard #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Aug 30, 2023
Merged

fixed broken links of testgrid dashboard #234

k8s-ci-robot merged 1 commit into from
Aug 30, 2023

Conversation

@siddhikhapare
Copy link
Contributor

@siddhikhapare siddhikhapare commented Aug 29, 2023

What type of PR is this?
/kind documentation

Which issue(s) this PR fixes:

Fixes kubernetes/test-infra#30370

@siddhikhapare siddhikhapare mentioned this pull request Aug 29, 2023
Closed
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 29, 2023
@k8s-ci-robot k8s-ci-robot requested review from humblec and pohly August 29, 2023 19:01
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 29, 2023

Welcome @siddhikhapare!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 29, 2023

Hi @siddhikhapare. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2023
pohly
pohly approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, siddhikhapare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@pohly
Copy link
Contributor

pohly commented Aug 30, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 984feec into kubernetes-csi:master Aug 30, 2023
@AdityaVardhanSingh
Copy link

AdityaVardhanSingh commented Aug 30, 2023

Hey, can you help me with how #30370 closed as there are other broken links remaining to be fixed?

@siddhikhapare
Copy link
Contributor Author

siddhikhapare commented Aug 30, 2023

@pohly Thank you for your guidance.

@letmerecall letmerecall mentioned this pull request Aug 31, 2023
Closed
40 tasks
mowangdk added a commit to mowangdk/external-health-monitor that referenced this pull request Oct 16, 2023
@mowangdk
Squashed 'release-tools/' changes from de2fba8..f9d5b9c
78c8ae8 
kubernetes-csi/csi-release-tools@f9d5b9c Merge kubernetes-csi/csi-release-tools#236 from mowangdk/feature/bump_csi-driver-host-path_version
kubernetes-csi/csi-release-tools@b01fd53 Bump csi-driver-host-path version up to v1.12.0
kubernetes-csi/csi-release-tools@984feec Merge kubernetes-csi/csi-release-tools#234 from siddhikhapare/csi-tools
kubernetes-csi/csi-release-tools@1f7e605 fixed broken links of testgrid dashboard

git-subtree-dir: release-tools
git-subtree-split: f9d5b9c05ef730f191dd31f2a012d6161d98bff6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humblec humblec Awaiting requested review from humblec

1 more reviewer

@pohly pohly pohly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pohly pohly

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Umbrella Issue] Update the mentions of testgrid dashboard URL from k8s-testgrid.appspot.com to testgrid.k8s.io

4 participants

@siddhikhapare @k8s-ci-robot @pohly @AdityaVardhanSingh