Skip to content

remove emeritus_reviewers#289

Closed
AnteBox wants to merge 1 commit intokubernetes-csi:masterfrom
AnteBox:master
Closed

remove emeritus_reviewers#289
AnteBox wants to merge 1 commit intokubernetes-csi:masterfrom
AnteBox:master

Conversation

@AnteBox
Copy link
Copy Markdown

@AnteBox AnteBox commented Feb 25, 2022

remove sections about emeritus reviewers

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
please see kubernetes/community#6334 for context

Which issue(s) this PR fixes:

remove sections about emeritus reviewers #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

remove sections about emeritus reviewers
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 25, 2022
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Feb 25, 2022

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 25, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @AnteBox!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AnteBox
To complete the pull request process, please assign xing-yang after the PR has been reviewed.
You can assign the PR to them by writing /assign @xing-yang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @AnteBox. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 25, 2022
@AnteBox
Copy link
Copy Markdown
Author

AnteBox commented Feb 25, 2022

/assign @xing-yang

@andyzhangx
Copy link
Copy Markdown
Member

that's a vendor change, need to change the go.mod and then run go mod tidy && go mod vendor

@andyzhangx andyzhangx closed this Feb 27, 2022
andyzhangx added a commit to andyzhangx/csi-driver-nfs that referenced this pull request Dec 19, 2025
b12e407c Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547 Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d Add myself as csi approver
c852fa79 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c10 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cc Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981 Bump actions/checkout from 5 to 6

git-subtree-dir: release-tools
git-subtree-split: b12e407cc9556acf6702ed8745d3f8a29c9169bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants