feat: add optional healthcheck for node-driver-registrar

[ajhetherington]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

Also technically an api change

What this PR does / why we need it:
This PR adds an optional healthcheck for the node-driver-registrar container, using it's healthcheck by enabling --http-endpoint (https://github.com/kubernetes-csi/node-driver-registrar?tab=readme-ov-file#health-check-with-the-http-server) & calling it with a livenessProbe.

Which issue(s) this PR fixes:

Fixes #1025

See #1025 (comment) for example of how it has resolved the issue.

Special notes for your reviewer:
This just changes the latest helm chart to use a feature added in node-driver-registrar, by default it will be disabled so won't have any changes for those using latest. Will need a new release (likely 4.13.0 as it changes the api)

Does this PR introduce a user-facing change?:

Adds nodeDriverRegistrar healthcheck, default disabled

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ajhetherington / name: Alex Hetherington (419f3a0, 0d5663f)

[k8s-ci-robot]

Welcome @ajhetherington!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ajhetherington. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coveralls]

Pull Request Test Coverage Report for Build 21511840528

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 78.582%

---

Totals
Change from base Build 21477725531:	0.0%
Covered Lines:	1108
Relevant Lines:	1410

---

💛 - Coveralls

[andyzhangx]

could you set --nodeDriverRegistrar.livenessProbe.enabled=true here? so e2e test would run with livenessProbe enabled:

csi-driver-nfs/Makefile

Line 45 in 94d48f6

E2E_HELM_OPTIONS ?= --set image.nfs.repository=$(REGISTRY)/$(IMAGENAME) --set image.nfs.tag=$(IMAGE_VERSION) --set image.nfs.pullPolicy=Always --set feature.enableInlineVolume=true --set externalSnapshotter.enabled=true --set controller.runOnControlPlane=true

[andyzhangx]

/ok-to-test

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajhetherington, andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment