cleanup: refine mount time out error message#1023
Merged
andyzhangx merged 1 commit intokubernetes-csi:masterfrom Dec 25, 2025
Merged
cleanup: refine mount time out error message#1023andyzhangx merged 1 commit intokubernetes-csi:masterfrom
andyzhangx merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
kind/cleanup
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
andyzhangx
requested review from
Copilot
and removed request for
gnufied and
mauriciopoppe
There was a problem hiding this comment.
Pull request overview
This PR refines the mount timeout error message in the NFS CSI driver to provide more detailed and actionable information when mount operations timeout. The changes improve observability by including the source, target path, and timeout duration in the error message.
Key Changes:
- Introduced a named constant for the mount timeout value (110 seconds)
- Enhanced the timeout error message to include source volume, target path, and timeout duration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 20502074527Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
cleanup: refine mount time out error message
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: