Make baseRepo feature work by default without per-image repository overrides

[Copilot]

What type of PR is this?

/kind feature

What this PR does / why we need it:

The baseRepo feature requires users to override every image repository with a /-prefixed path to work. This defeats the purpose of having a single config to redirect all images.

Changes:

• Update values.yaml repository values to use relative paths (/sig-storage/csi-provisioner instead of full registry.k8s.io/sig-storage/csi-provisioner)
• Keep nfs.repository as full path since it uses staging registry (gcr.io/k8s-staging-sig-storage/nfsplugin)
• Update hack/verify-helm-chart.sh to handle baseRepo concatenation

Before:

image:
  baseRepo: yourcache.azurecr.io
  csiProvisioner:
    repository: /sig-storage/csi-provisioner  # had to override each one
  csiResizer:
    repository: /sig-storage/csi-resizer
  # ... repeat for all images

After:

image:
  baseRepo: yourcache.azurecr.io
  # That's it - all images now use the custom registry

Which issue(s) this PR fixes:

Fixes #822

Special notes for your reviewer:

The nfs image intentionally keeps its full path since the latest/canary chart uses gcr.io/k8s-staging-sig-storage which differs from the default baseRepo. Users can still override it with /sig-storage/nfsplugin if desired.

Does this PR introduce a user-facing change?:

helm: baseRepo now works by default without requiring individual repository overrides for each image

Original prompt

---

This section details on the original issue you should resolve

<issue_title>baseRepo feature is difficult to use</issue_title>
<issue_description>Is your feature request related to a problem?/Why is this needed

The baseRepo feature is difficult to use because the repository tags here:

csi-driver-nfs/charts/v4.12.1/csi-driver-nfs/values.yaml

Line 5 in cc21103

repository: registry.k8s.io/sig-storage/nfsplugin

include the baseRepo in the line. To redirect all images you now need to write this:

image:
  baseRepo: yourcache.azurecr.io/registry-k8s-io
  nfs: 
    repository: /sig-storage/nfsplugin
  csiProvisioner:
    repository: /sig-storage/csi-provisioner
  csiResizer:
    repository: /sig-storage/csi-resizer
  csiSnapshotter:
    repository: /sig-storage/csi-snapshotter
  livenessProbe:
    repository: /sig-storage/livenessprobe
  nodeDriverRegistrar:
    repository: /sig-storage/csi-node-driver-registrar
  externalSnapshotter:
    repository: /sig-storage/snapshot-controller

because the baseRepo feature only works if the repository starts with a /

csi-driver-nfs/charts/v4.12.1/csi-driver-nfs/templates/csi-nfs-controller.yaml

Line 63 in cc21103

{{- if hasPrefix "/" .Values.image.csiProvisioner.repository }}

If the registry was removed from all the repository sections as above

repository: /sig-storage/nfsplugin

the chart would use the base repo by default, then anyone wanting to override it would just need to do something like:

image:
  baseRepo: yourcache.azurecr.io/registry-k8s-io

and omit the setting of each components repo.
</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes baseRepo feature is difficult to use #991

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[k8s-ci-robot]

Hi @Copilot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andyzhangx]

/ok-to-test

[coveralls]

Pull Request Test Coverage Report for Build 19808693758

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 78.693%

---

Totals
Change from base Build 19665733572:	0.0%
Covered Lines:	1108
Relevant Lines:	1408

---

💛 - Coveralls

[andyzhangx]

/retest

[andyzhangx]

/retest

[andyzhangx]

/retest

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment