Skip to content

Add nfs csi driver#1

Closed
prateekpandey14 wants to merge 3 commits intokubernetes-csi:masterfrom
prateekpandey14:add-nfs-diver
Closed

Add nfs csi driver#1
prateekpandey14 wants to merge 3 commits intokubernetes-csi:masterfrom
prateekpandey14:add-nfs-diver

Conversation

@prateekpandey14
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prateekpandey14
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: childsb

If they are not already assigned, you can assign the PR to them by writing /assign @childsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2019
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
Comment thread pkg/nfs/driver.go
"github.com/container-storage-interface/spec/lib/go/csi"
"github.com/golang/glog"

csicommon "github.com/kubernetes-csi/drivers/pkg/csi-common"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe "github.com/kubernetes-csi/drivers" is supposed to be deprecated once all the drivers have been moved to their own respective repo. Maybe we should not use this library?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathu97 right , but i can see there is https://github.com/kubernetes-csi/csi-lib-common where we will move out the csi-common code base , which can be used later by the other drivers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, i didn't realize that there was such a repo. Sounds good.

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Feb 7, 2019

Is it possible to move this over and retain the commit history?

@prateekpandey14
Copy link
Copy Markdown
Contributor Author

@msau42 I will retain the commit history.. thanks

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Feb 8, 2019

cc @bswartz

@prateekpandey14
Copy link
Copy Markdown
Contributor Author

Raised PR #2 with retain commit history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants