Skip to content

Support rust#192

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
alberthuang24:support-rust
Jun 17, 2021
Merged

Support rust#192
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
alberthuang24:support-rust

Conversation

@alberthuang24
Copy link
Contributor

@alberthuang24 alberthuang24 commented Jun 8, 2021

I have generated and tested this https://github.com/HongjiangHuang/kube-rust repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from yliaog and yue9944882 June 8, 2021 07:42
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2021
@brendandburns
Copy link
Contributor

This looks good to me, do you have a repo somewhere that has the generated code?

@alberthuang24 alberthuang24 changed the title WIP Support rust Support rust Jun 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2021
@alberthuang24
Copy link
Contributor Author

I have generated and tested this https://github.com/HongjiangHuang/kube-rust repository.
Now you can wait for this PR to merge or export OPENAPI_GENERATOR_COMMIT=381af95daf00055dbc1cffda9e17c6e90e95f886

@brendandburns
Copy link
Contributor

/lgtm

Once that generator fix is merged, I will approve this.

Once it is approved, the next step is to apply for a new repo in https://github.com/kubernetes/org

Here's the one that added 'C' for reference:

kubernetes/org#1700

We will need two maintainers for the library, I assume you are interested in being one of them. I will sign up to be the other one.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2021
@alberthuang24
Copy link
Contributor Author

We will need two maintainers for the library, I assume you are interested in being one of them. I will sign up to be the other one.

I am very happy to, Thank you

@brendandburns
Copy link
Contributor

Great. Please ping this PR again when the openapi-client fix merges and we can merge this PR and then move on to officially adding the repo.

@alberthuang24
Copy link
Contributor Author

Hi, @brendandburns

Now the pr OpenAPITools/openapi-generator#9745 has been merged.

@zmrush
Copy link

zmrush commented Jun 17, 2021

i'm interested in it

@brendandburns
Copy link
Contributor

/approve

The next step is to create the appropriate repo (https://github.com/kubernetes-client/rust) and populate it with the generated code.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, HongjiangHuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit fcf2c94 into kubernetes-client:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants