Skip to content

Conversation

@Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Aug 26, 2024

What this PR does / why we need it:
Change isort profile to black for full compatibility as per @andreyvelich request

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Ygnas added 2 commits August 26, 2024 16:33
Signed-off-by: Ignas Baranauskas <[email protected]>
@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10562711788

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 33.469%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 81.05%
Totals Coverage Status
Change from base Build 10512072223: -0.02%
Covered Lines: 3949
Relevant Lines: 11799

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 25b8a5b into kubeflow:master Aug 27, 2024
szaher pushed a commit to szaher/sdk that referenced this pull request Jun 4, 2025
…r#2234)

* Change isort profile to black for full compatibility

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix isort formatting

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
szaher pushed a commit to szaher/sdk that referenced this pull request Jun 4, 2025
…r#2234)

* Change isort profile to black for full compatibility

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix isort formatting

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
szaher pushed a commit to szaher/sdk that referenced this pull request Jun 4, 2025
…r#2234)

* Change isort profile to black for full compatibility

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix isort formatting

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
szaher pushed a commit to szaher/sdk that referenced this pull request Jun 5, 2025
…r#2234)

* Change isort profile to black for full compatibility

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix isort formatting

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants