Refine optional Kubernetes runtime test pipeline #12399
Conversation
|
Hi @sduvvuri1603. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
|
/ok-to-test |
|
/ok-to-test |
|
/lgtm |
sduvvuri1603
force-pushed
the
fix/optional-k8s-followup
branch
from
04e7bd3 to
5cbccda
Compare
|
@sduvvuri1603 Please add the TestData entry for new Pipeline here- https://github.com/kubeflow/pipelines/blob/master/sdk/python/test/compilation/pipeline_compilation_test.py#L271. |
sduvvuri1603
force-pushed
the
fix/optional-k8s-followup
branch
2 times, most recently
from
12d70b9 to
b5d93cb
Compare
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
Signed-off-by: sduvvuri1603 <[email protected]>
sduvvuri1603
force-pushed
the
fix/optional-k8s-followup
branch
from
b5d93cb to
8c54f94
Compare
|
/lgtm |
| with dsl.If(enable_affinity == True): | ||
| affinity_task = log_message(message="node affinity applied") | ||
| affinity_task.set_caching_options(enable_caching=False) | ||
| if optional_affinity is not None: |
There was a problem hiding this comment.
You can't use conditionals like this in a dsl.pipeline because this code executes at compile time, not runtime.
Just remove the if statements. We also want to always apply the unset Kubernetes configuration to test your new code.
There was a problem hiding this comment.
My bad. Removed the if statements and pushed the updated code changes.
Signed-off-by: sduvvuri1603 <[email protected]>
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Description of changes
missing_kubernetes_optional_inputs_pipelineto a singlelog_messagetask and apply every K8s helper directly on that task.optional_image_pull_secret_nameso image pull secrets participate in the skip logic.dsl.Ifguards; the helpers now see either real values ornull, letting the driver hit both the “patch applied” path and theErrResolvedParameterNullskip path.