Skip to content

Conversation

@HarshitR2004
Copy link

Description of your changes:

log_metric() previously failed when a metric value was NaN, causing component errors.

This change adds a check to skip NaN values and issue a warning instead:

if math.isnan(value):
    warnings.warn(f'Metric "{metric}" is NaN and will be skipped.', stacklevel=2)
    return

Fixes #12227

Checklist:

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @HarshitR2004. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@HarshitR2004 HarshitR2004 force-pushed the fix/log_metrics-handle-nan-values branch from 3468efc to 5847088 Compare October 24, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] log_metric() fails when logging NaN values, causing component failures

1 participant