chore: add repo agnosticism to e2e/integration tests #12378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HumairAK
force-pushed
the
repo_agnostic
branch
from
cf8c052 to
95707e2
Compare
Signed-off-by: Humair Khan <[email protected]>
HumairAK
force-pushed
the
repo_agnostic
branch
from
95707e2 to
6e4fc9c
Compare
mprahl
reviewed
Oct 20, 2025
| if: ${{ steps.forward-mysql-port.outcome == 'success' }} | ||
| working-directory: ./backend/test/integration | ||
| run: go test -v ./... -args -runIntegrationTests=true -namespace=kubeflow | ||
| run: go test -v ./... -args -runIntegrationTests=true -namespace=kubeflow -repoName=${{ github.repository }} -branchName=${{ github.event.repository.default_branch }} |
Collaborator
There was a problem hiding this comment.
Should we use github.ref_name instead so the release branch pushes are using the correct code? I think github.event.repository.default_branch always points to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that we are not hardcoding repo names, branches, and also ensure we pick source files from PRs in CI for integration tests.