-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(SDK): Add SemaphoreKey and MutexName fields to DSL #11340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae9192a to
65dd821
Compare
|
couple nitpicks but overall lgtm. I don't want to merge it until the backend PR is posted and close to shipping. |
c3178ce to
15b89b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
lgtm but let's wait until the backend PR is ready to go too
edit: need to use the right protoc version when generating the pipeline_spec files
39665e1 to
8ef1f2d
Compare
|
can we add a test where we verify the semaphore setting compiles to the expected IR? |
8ef1f2d to
8a7b0e5
Compare
|
Edit: Updated to have the DSL generated |
still need to do this. Here's an example: |
8a7b0e5 to
8db319b
Compare
Yes I'm working on this ATM. I'm adding a unit test to the
Have a draft ready, testing locally and pushing it in a bit. |
a0e94f1 to
32f5d01
Compare
f14c9a5 to
3c42c15
Compare
Signed-off-by: ddalvi <[email protected]> Add tests to verify setting of SemaphoreKey and MutexName fields in DSL Signed-off-by: ddalvi <[email protected]> Implement getter setter functions with latest Pythonic properties Signed-off-by: ddalvi <[email protected]>
3c42c15 to
e997d42
Compare
mprahl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold for @gmfrasca to review again
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gmfrasca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold
Description of your changes:
This PR introduces
semaphoreKeyandmutexNamefields inPipelineConfigto support pipeline-level concurrency controls in KFP SDK.This PR should be merged only after #11384 gets merged.
Testing instructions
Create a Python virtualenv and install the SDK and IR YAML API packages locally:
Use the example code to compile
You should be able to compile and find the following snippet in the main.yaml file:
Checklist: