Reconsider Katib Metrics Collector Injection Label

[andreyvelich]

/kind discussion

To be consistent with these PRs: #1611, #1621, we might change our katib-metricscollector-injection: enabled label.

My suggestion is to name this label like this: katib.kubeflow.org/metrics-collector-injection: enabled
This will require Profile Controller changes.

Checklist:

• Modify Katib manifests. Change namespace label for metrics collector injection #1740.
• Modify Profile controller. Change namespace label for Katib metrics collector injection kubeflow#6225

What do you think @gaocegege @alculquicondor @johnugeorge @yanniszark ?

[gaocegege]

Should we use katib or automl? automl.kubeflow.org/xxx

[alculquicondor]

katib.kubeflow.org/metrics-collector-injection sgtm for consistency with #1611

[gaocegege]

Then SGTM

[johnugeorge]

Do we still need this label in the namespace ?

[andreyvelich]

Do we still need this label in the namespace ?

Yes, we allow to submit Katib Experiments only in namespace with this label: https://github.com/kubeflow/katib/blob/master/pkg/webhook/v1beta1/experiment/validation_webhook.go#L91.

[andreyvelich]

/area release

[andreyvelich]

We can close this issue.