add govulncheck scan to Makefile

[sheharyaar]

Signed-off-by: Mohammad Shehar Yaar Tausif [email protected]

[sheharyaar]

It includes the test files via the -test flag

[kranurag7]

Hey @sheharyaar With the latest version of govulncheck, -v flag is not defined anymore, so we don't need that anymore. Rest looks good to me.

[sheharyaar]

Sure, will make the required changes.

[sheharyaar]

@kranurag7 it's done

[kranurag7]

LGTM @sheharyaar, thanks for working on this.

[sheharyaar]

It's done

[daemon1024]

Will adding it to CI be a different task, @kranurag7 @sheharyaar ?

[kranurag7]

Will adding it to CI be a different task, @kranurag7 @sheharyaar ?

Can be handled in a separate PR using this reusable action https://github.com/golang/govulncheck-action
It also requires more work, I'm not sure if the action returns a non-zero exit code when it finds some vulnerabilities. A good thing would be to take a look at how other repos are using this reusable action.
Ref: https://github.com/search?q=path%3A%2F%5E.github%5C%2Fworkflows%2F+golang%2Fgovulncheck&type=code