Re-add support for basic auth in Proxy#1959
Merged
Merged
Conversation
Signed-off-by: goenning <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
=======================================
+ Coverage 76.3% 76.3% +0.1%
=======================================
Files 89 89
Lines 8507 8512 +5
=======================================
+ Hits 6486 6492 +6
+ Misses 2021 2020 -1
🚀 New features to boost your workflow:
|
clux
approved these changes
Mar 15, 2026
Member
clux
left a comment
There was a problem hiding this comment.
this seems sensible to me. thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When kube-rs moved from hyper-http-proxy to hyper-util, support for Basic Auth was lost as this was previously done inside the crate.
Solution
This PR adds support for auth again inside kube-rs as it seems like the hyper-util is avoiding anything new being added to their legacy modules.