Add a metadata field to Status#1891
Conversation
0ca968a to
d535020
Compare
| /// | ||
| /// ``` | ||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq)] | ||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq)] |
There was a problem hiding this comment.
This struct contains a Status so the Eq change propagates up
Signed-off-by: Ryan Brewster <[email protected]>
d535020 to
221479e
Compare
ahhh. lol. i don't remember that being there. yeah, maybe they should be the same. however it's needed right now for a deprecation note so don't want to change it right now for the next version. as long as they are the same, it's not a problem for now. maybe in the next version we can change our Status to a re-export of k8s-openapi's generated Status. |
i think this is fine, we are already touching |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
=======================================
+ Coverage 76.0% 76.0% +0.1%
=======================================
Files 85 85
Lines 8329 8336 +7
=======================================
+ Hits 6325 6334 +9
+ Misses 2004 2002 -2
🚀 New features to boost your workflow:
|
Signed-off-by: Ryan Brewster <[email protected]>
Signed-off-by: Ryan Brewster <[email protected]>
This is a fresh attempt at #1809
The motivation is summarized in #1890
Reviewer notes:
ListMetafield directly from k8s-openapi. This...kind of feels weird, since the kube_core::Status is now extremely similar to the k8s-openapiStatus. Should these just be the same struct?ListMetadoes not implEq, so I removed it fromStatus. As such, this PR is a breaking change in at least 2 ways (it adds a new field, and it removes an impl).I can manually impl
Eq(which is safe right now, but may become unsafe in the future). I can also use a separate struct that is wire-compatible with the k8s-openapi struct (I'd probably only define the continue token initially). Preferences?