Skip to content

admission_controller example: replace warp with axum#1859

Merged
clux merged 3 commits into
kube-rs:mainfrom
nightkr:example/admission-controller-axum
Dec 7, 2025
Merged

admission_controller example: replace warp with axum#1859
clux merged 3 commits into
kube-rs:mainfrom
nightkr:example/admission-controller-axum

Conversation

@nightkr
Copy link
Copy Markdown
Member

@nightkr nightkr commented Dec 7, 2025

Fixes #1808, fixes #1858, replaces #1833

Motivation

Axum has a fair bit more mindshare these days, and is more likely to be familiar to people coming in from other Rust API projects.

Solution

Overall, things map pretty 1:1. axum-server is a third-party crate, but is also used in axum's TLS example.

@nightkr nightkr requested a review from a team December 7, 2025 05:16
@nightkr nightkr self-assigned this Dec 7, 2025
Fixes kube-rs#1808, fixes kube-rs#1858, replaces kube-rs#1833

Axum has a fair bit more mindshare these days, and is more likely to be
familiar to people coming in from other Rust API projects.

Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
@nightkr nightkr force-pushed the example/admission-controller-axum branch from 5e78b2c to fb7ac19 Compare December 7, 2025 05:18
Copy link
Copy Markdown
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.7%. Comparing base (a4b799e) to head (a018f03).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1859     +/-   ##
=======================================
- Coverage   74.7%   74.7%   -0.0%     
=======================================
  Files         84      84             
  Lines       7938    7938             
=======================================
- Hits        5927    5923      -4     
- Misses      2011    2015      +4     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This reverts commit 2f7817a.

Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
@nightkr nightkr enabled auto-merge December 7, 2025 05:30
@clux clux disabled auto-merge December 7, 2025 05:31
@clux clux merged commit bb567bd into kube-rs:main Dec 7, 2025
15 of 16 checks passed
@nightkr nightkr deleted the example/admission-controller-axum branch December 7, 2025 05:31
@clux clux added this to the 3.0.0 milestone Dec 7, 2025
@clux clux added the changelog-exclude changelog excluded prs label Dec 7, 2025
@clux clux mentioned this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-exclude changelog excluded prs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2025-0134: rustls-pemfile is unmaintained Replace or fix warp in admission_controller example

2 participants