Skip to content

Conversation

@saif-88
Copy link
Contributor

@saif-88 saif-88 commented Aug 14, 2025

Motivation

This PR fixes the initialisation of the with oidc and openssl see issue

Solution

changing hyper_openssl::HttpsConnector to the new hyper_openssl::client::legacy::HttpsConnector and adding tokio feature to hyper-openssl as it's needed by the HttpsConnector

@clux clux added the changelog-fix changelog fix category for prs label Aug 15, 2025
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.3%. Comparing base (10b47f1) to head (18efbfb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1807     +/-   ##
=======================================
- Coverage   76.4%   76.3%   -0.0%     
=======================================
  Files         84      84             
  Lines       7899    7899             
=======================================
- Hits        6027    6020      -7     
- Misses      1872    1879      +7     
Files with missing lines Coverage Δ
kube-client/src/client/auth/oidc.rs 56.6% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clux
Copy link
Member

clux commented Aug 15, 2025

Hey, thanks for this, LGTM. If you are able to do the --signoff on it (DCO check), we can merge it in.

Signed-off-by: saifallah ben ali <[email protected]>
@saif-88
Copy link
Contributor Author

saif-88 commented Aug 15, 2025

--signoff done :)

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@clux clux merged commit 82fb2cb into kube-rs:main Aug 15, 2025
15 of 17 checks passed
@clux clux added this to the next-major milestone Aug 15, 2025
@clux clux mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-fix changelog fix category for prs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants