Clamp scheduling delay to 6 months#1779
Merged
Merged
Conversation
Signed-off-by: dervoeti <[email protected]>
5c4be2e to
9f1261b
Compare
clux
approved these changes
Jun 25, 2025
Member
clux
left a comment
There was a problem hiding this comment.
clean solution. thank you very much!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
=======================================
+ Coverage 76.5% 76.5% +0.1%
=======================================
Files 84 84
Lines 7895 7896 +1
=======================================
+ Hits 6034 6038 +4
+ Misses 1861 1858 -3
🚀 New features to boost your workflow:
|
20 tasks
nightkr
reviewed
Jun 25, 2025
Member
nightkr
left a comment
There was a problem hiding this comment.
Implementation LGTM. Just a few comment nits.
Co-authored-by: Natalie Klestrup Röijezon <[email protected]> Signed-off-by: Lukas Krug <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]> Signed-off-by: Lukas Krug <[email protected]>
Signed-off-by: dervoeti <[email protected]>
nightkr
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1772 (long durations cause panics in DelayQueue.html#method.insert_at and DelayQueue.html#method.reset_at).
Solution
Clamp the scheduling delay to a maximum of 6 months. This value is now also used as fallback if
checked_addfails.