Add find_all method to Store

[pando85]

Resolves #1633.

Motivation

Solution

[pando85]

I tried to return an Slice or an iterator but it requires a collect anyway because store is behind a RwLock.

[clux]

Thanks a lot! LGTM.

(Please disregard lint error, false positive known issue silenced in #1636 )

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (9c402a6) to head (9f04a48).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
kube-runtime/src/reflector/store.rs	0.0%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #1634     +/-   ##
=======================================
- Coverage   75.3%   75.3%   -0.0%     
=======================================
  Files         82      82             
  Lines       7348    7351      +3     
=======================================
  Hits        5528    5528             
- Misses      1820    1823      +3     

Files with missing lines	Coverage Δ
kube-runtime/src/reflector/store.rs	94.7% <0.0%> (-2.2%)	⬇️

[SOF3]

it requires a collect anyway because store is behind a RwLock.

can't you move the RwLockReadGuard into the returned iterator?

[pando85]

I don't understand your point @SOF3 . Could you elaborate on it a bit?

[SOF3]

I am just confused why we need so many special methods on Store instead of exposing a map-like API that provides iter(). Is it simply because we don't want to implement a custom Iterator type that owns its own RwLockReadGuard?

[pando85]

@SOF3 that's a good point. In deed, we already have the state method which returns an iterator through all the objects.

I can close this and use that method.

Thank you both.