Performance improvement for helpers #2001

stijnvanhulle · 2025-11-06T13:58:27Z

Summary by CodeRabbit

New Features
- Expanded public schemas and endpoints for apps, machines, volumes, secrets, tokens, metadata.
Performance
- Faster generation by parallelizing schema and operation builds.
Improvements
- More robust mocks and file-matching with deduplication and safer error handling.
- Improved timeout/delay lifecycle behavior.
- Simplified logging/event handling and consolidated file emission.
- New keyword helpers exported for more reliable schema parsing and mapping.

changeset-bot · 2025-11-06T13:58:31Z

⚠️ No Changeset found

Latest commit: 4ba4ed2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dosubot · 2025-11-06T13:58:40Z

Related Documentation

Checked 1 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}

coderabbitai · 2025-11-06T13:59:59Z

Warning

Rate limit exceeded

@stijnvanhulle has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between bd91869 and 4ba4ed2.

📒 Files selected for processing (1)

biome.json (1 hunks)

Walkthrough

Refactors PluginManager mock signatures and matchFiles (deduplication, parsing/formatting), makes format async with early returns, resolves timeouts with handles and clears them, parallelizes plugin-zod generation and consolidates emissions, adds many generated Zod schemas, and updates a minor ignore pattern.

Changes

Cohort / File(s)	Summary
Mocks & file matching `configs/mocks.ts`	Reworked PluginManager mock: removed `Plugin` import; `format` is now async with early-return for falsy source and returns original source on error; `resolveName` refactored to switch mapping (camelCase/pascalCase); `logger.on` changed to no-arg function; `getPluginByKey` now no-arg; `getFile` meta simplified; final cast changed to `as unknown as PluginManager`; `matchFiles` now guards empty input, deduplicates by `file.path`, parses once, skips formatting for `.json` baseNames, snapshots with optional pre-folder, and returns a processed map.
Generated schemas (large) `examples/simple-single/src/gen2/index.ts`	Adds an extensive set of exported Zod schemas and related request/response/path/query/mutation types for apps, machines, volumes, secrets/secretkeys, tokens, placements/regions, IP assignments, leases, and related endpoints; removes the previous apps-block at file end.
Plugin Zod generator `packages/plugin-zod/src/plugin.ts`	Runs schema and operation generators in parallel via `Promise.all`, consolidates emissions into a single `addFile` call combining schema/operation/barrel files, and simplifies barrel meta formatting.
Timeout utilities & example config `packages/core/src/utils/timeout.ts`, `examples/zod/kubb.config.js`	Timeout wrappers now resolve with the setTimeout handle and clear the timeout in a subsequent `.then(...)` instead of resolving booleans or inline clearing.
OAS schema mapper & exports `packages/plugin-oas/src/SchemaMapper.ts`, `packages/plugin-oas/src/index.ts`	Adds helpers: `createSchemaKeywordMap`, `createSchemaKeywordSet`, `getSchemaByKeyword`, `hasKeyword`; re-exports them alongside existing `isKeyword`/`schemaKeywords`.
Parsers updated to use keyword helpers `packages/plugin-faker/src/parser.ts`, `packages/plugin-ts/src/parser.ts`, `packages/plugin-zod/src/parser.ts`	Refactors object property handling to use new keyword-map/set helpers (`createSchemaKeywordMap`, `createSchemaKeywordSet`, `getSchemaByKeyword`, `hasKeyword`), centralizes per-property keyword extraction and mapping, and updates property/type construction logic.
Schema traversal robustness `packages/plugin-oas/src/SchemaGenerator.ts`	Replaces optional-chaining-based traversal with explicit guards and for-of loops in `deepSearch` and `find`, making recursion and early returns more explicit.
Misc config `biome.json`	Minor ignore pattern update: replace excluded `ceviz-report.htm` with `ceviz-report.html`.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Focus review on behavioral/signature changes in configs/mocks.ts (caller compatibility for getPluginByKey, logger.on, format, and matchFiles behavior).
Verify plugin parsers (plugin-zod, plugin-ts, plugin-faker) correctly use the new keyword helpers and maintain previous semantics for optional/nullable/ref handling.
Check plugin-zod parallelization for potential race conditions or ordering assumptions when combining files into a single emission.
Scan the large generated schema file for naming conflicts, missing exports, or unintended removals.

Possibly related PRs

Fix/1669 #1714 — adds/changes the same SchemaMapper helpers (createSchemaKeywordMap, createSchemaKeywordSet, getSchemaByKeyword, hasKeyword) and overlaps parser updates.
feat: Support for custom formatters(prettier, biome) and linters(eslint, oxlint, biome) #1847 — touches formatter and mocks codepaths; likely related to format and matchFiles changes in configs/mocks.ts.
Update fabric #2002 — modifies configs/mocks.ts and mocked PluginManager behavior; strongly related to the mock refactors here.

Suggested labels

@kubb/plugin-oas

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main focus of the changeset—optimizing helper functions and refactoring for improved performance across multiple modules.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2025-11-06T14:00:30Z

More templates

@kubb/cli

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/cli@2001

@kubb/core

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/core@2001

kubb

npm i https://pkg.pr.new/kubb-labs/kubb@2001

@kubb/mcp

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/mcp@2001

@kubb/oas

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/oas@2001

@kubb/plugin-client

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-client@2001

@kubb/plugin-cypress

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-cypress@2001

@kubb/plugin-faker

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-faker@2001

@kubb/plugin-mcp

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-mcp@2001

@kubb/plugin-msw

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-msw@2001

@kubb/plugin-oas

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-oas@2001

@kubb/plugin-react-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-react-query@2001

@kubb/plugin-redoc

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-redoc@2001

@kubb/plugin-solid-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-solid-query@2001

@kubb/plugin-svelte-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-svelte-query@2001

@kubb/plugin-swr

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-swr@2001

@kubb/plugin-ts

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-ts@2001

@kubb/plugin-vue-query

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-vue-query@2001

@kubb/plugin-zod

npm i https://pkg.pr.new/kubb-labs/kubb/@kubb/plugin-zod@2001

unplugin-kubb

npm i https://pkg.pr.new/kubb-labs/kubb/unplugin-kubb@2001

commit: 4ba4ed2

kubb-labs-dev · 2025-11-06T14:01:10Z

The preview deployment for kubb-labs/kubb:main is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-11-20 22:25:24 CET

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

examples/zod/kubb.config.js (1)
8-14: Consider using the timeout utility instead of duplicating the logic.

This implements the same timeout pattern as the utility in packages/core/src/utils/timeout.ts. Consider importing and using that utility to reduce code duplication.

Apply this diff:
 import { defineConfig } from '@kubb/core'
+import { timeout } from '@kubb/core'
 import { pluginClient } from '@kubb/plugin-client'
 import { pluginOas, schemaKeywords } from '@kubb/plugin-oas'
 import { pluginTs } from '@kubb/plugin-ts'
 import { pluginZod } from '@kubb/plugin-zod'

 export default defineConfig(async () => {
-  await new Promise((resolve) => {
-    const timeout = setTimeout(() => {
-      resolve(timeout)
-    }, 1000)
-  }).then((timeout) => {
-    clearTimeout(timeout)
-  })
+  await timeout(1000)

   return {

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 996d2ab and 2ccfba5.

⛔ Files ignored due to path filters (1)

examples/simple-single/src/gen/zod.ts is excluded by !**/gen/**

📒 Files selected for processing (5)

configs/mocks.ts (3 hunks)
examples/simple-single/src/gen2/index.ts (6 hunks)
examples/zod/kubb.config.js (1 hunks)
packages/core/src/utils/timeout.ts (1 hunks)
packages/plugin-zod/src/plugin.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (3)

packages/plugin-zod/src/plugin.ts (1)

packages/core/src/utils/getBarrelFiles.ts (1)

getBarrelFiles (36-76)

examples/zod/kubb.config.js (1)

packages/core/src/utils/timeout.ts (1)

timeout (1-9)

configs/mocks.ts (1)

packages/core/src/PluginManager.ts (1)

PluginManager (78-708)

🪛 Biome (2.1.2)

examples/simple-single/src/gen2/index.ts

[error] 71-71: This variable is used before its declaration.

The variable is declared here: