Adds the ability to create forks #91
Conversation
go.mod
Outdated
|
|
||
| require ( | ||
| github.com/golang/protobuf v1.0.0 | ||
| github.com/golang/protobuf v1.0.0 // indirect |
There was a problem hiding this comment.
Would you remove the line if it is not a problem?
| //} | ||
| if ro.IsPrivate != "" { | ||
| body["is_private"] = ro.IsPrivate | ||
| body["is_private"] = strings.ToLower(strings.TrimSpace(ro.IsPrivate)) != "false" |
There was a problem hiding this comment.
I thought the below was the right one, and do you think?
| body["is_private"] = strings.ToLower(strings.TrimSpace(ro.IsPrivate)) != "false" | |
| body["is_private"] = strings.ToLower(strings.TrimSpace(ro.IsPrivate)) |
There was a problem hiding this comment.
@ktrysmt Bitbucket expects a boolean value in the payload for the is_private field. If you try and submit a request with the previous code you get the error:
{"type": "error", "error": {"fields": {"is_private": "expected bool"}, "message": "Bad request"}}
The new condition of != makes the value a real boolean, which is what Bitbucket expects. Check the schema here.
There was a problem hiding this comment.
I see.
I understood that is_private: boolean is detected at the site.
| //} | ||
| if ro.IsPrivate != "" { | ||
| body["is_private"] = ro.IsPrivate | ||
| body["is_private"] = strings.ToLower(strings.TrimSpace(ro.IsPrivate)) != "false" |
There was a problem hiding this comment.
I see.
I understood that is_private: boolean is detected at the site.
|
Please see the new release at https://github.com/ktrysmt/go-bitbucket/releases/tag/v0.6.2 |
2 participants
Adds the ability to create forks and fixes the "is_private" parameter (it's supposed to be boolean and not a string).