Skip to content

Conversation

@samcontesse
Copy link
Contributor

Goal

Pull request with reviewers can't be submitted anymore due to this API deprecation. This change replace username by uuid which seems to be the only way to submit PR with reviewers.

Another change is also introduced to have strong type on the User profile resource.

Breaking changes

Reviewers must be submitted as uuid and not username. Note that curly braces surround the uuid. See documentation

Copy link
Owner

@ktrysmt ktrysmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the API doc and understood that "account_id or uuid should be used to identify an account instead".
LGTM.

@ktrysmt ktrysmt merged commit 87ce546 into ktrysmt:master Jun 8, 2020
@ktrysmt
Copy link
Owner

ktrysmt commented Jun 8, 2020

Thank you for your contribution.
I have released it. Please check it out. @samcontesse
https://github.com/ktrysmt/go-bitbucket/releases/tag/v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants