Skip to content

Conversation

@csandanov
Copy link
Contributor

I've noticed there're many changes in master that aren't in 0.4.1. Do you plan to release a new tag or should we using the master branch?

@ktrysmt
Copy link
Owner

ktrysmt commented Oct 25, 2019

Thank you for your contribution and suggestion.

Basically there is no room for maintenance for each minor version. But I understand your desire to be provided a tag. So, I will provide tags from this time. @csandanov

@ktrysmt
Copy link
Owner

ktrysmt commented Oct 25, 2019

I provided a tag of v5.0.0 at once. It is released from current master (e8d45e2).
Would you please check it?
https://github.com/ktrysmt/go-bitbucket/releases/tag/v5.0.0

And I will review this PR then release new tag 5.1.0.

@csandanov
Copy link
Contributor Author

I'm currently using the fork with the list tags method I've added, on master branch. Works fine for me but I use just a few methods, a couple of them are new, I think, – list files and get file contents.

@ktrysmt
Copy link
Owner

ktrysmt commented Oct 28, 2019

Thank you for your reporting. I referenced it and I will merge it. LGTM.

@ktrysmt ktrysmt merged commit 388db12 into ktrysmt:master Oct 28, 2019
@ktrysmt
Copy link
Owner

ktrysmt commented Oct 28, 2019

@csandanov
Copy link
Contributor Author

csandanov commented Oct 28, 2019

Hm... I'm not sure why you named the new version v5.x.x after there was only v0.4.1
Now go modules gives the following error:

version "v5.1.0" invalid: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v5

And it does so because of https://github.com/golang/go/wiki/Modules#semantic-import-versioning:

If the module is version v2 or higher, the major version of the module must be included as a /vN at the end of the module paths used in go.mod files

So I guess if you want to stick to this v5, you should update your go.mod file and add /v5 at the end of the first line. This way we'll be able to import it as github.com/ktrysmt/go-bitbucket/v5

@ktrysmt
Copy link
Owner

ktrysmt commented Oct 28, 2019

Oh sorry, I missed that rules of go.mods' versioning.
I will fix it to be suitable.
Thank you for explain to me! @csandanov

@ktrysmt
Copy link
Owner

ktrysmt commented Oct 29, 2019

I re-released some tags about here.
I will so use v0.. for the time being that this project is still experimental and uncompletable. @csandanov

https://github.com/ktrysmt/go-bitbucket/releases

@csandanov
Copy link
Contributor Author

Thank you! it's all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants