Add file support #65
Merged
Add file support #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to list files and retrieve blobs from Bitbucket.
mfb2
commented
Jul 25, 2019
| return c | ||
| } | ||
|
|
||
| func (c *Client) executeRaw(method string, urlStr string, text string) ([]byte, error) { |
Contributor
Author
There was a problem hiding this comment.
When requesting file content from Bitbucket, a blob is returned; however, the existing execute and doRequest functions expected a JSON payload to be returned. As such, execute / doRequest in their prior state resulted in errors due to an attempt to parse the response. These new functions were introduced to get the raw payload back from the Bitbucket API and pass that along to the consumer.
Owner
There was a problem hiding this comment.
That's right, and I understood it. LGTM! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to list files and retrieve blobs from
Bitbucket.