KTOR-5492 Javadoc for Resources.kt cannot be compiled #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helpermethod
changed the title
helpermethod
force-pushed
the
fix/KTOR-5492
branch
from
fdd1318 to
2f994f6
Compare
rsinukov
approved these changes
Feb 13, 2023
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Motivation
The JavaDoc in its current form does not compile as the
Usersdata class must have at least one primary constructor parameter, which it doesn't. See KTOR-5492 for more details.Solution
Replaces the data classes in the example with normal classes analogue to the examples in the documentation.