Skip to content

KTOR-5099 Fix memory leak in HttpRequestRetry plugin #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsinukov merged 1 commit into from
Dec 14, 2022
Merged

KTOR-5099 Fix memory leak in HttpRequestRetry plugin #3316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/HttpRequestRetry.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,11 @@ public class HttpRequestRetry internal constructor(configuration: Configuration)

private fun prepareRequest(request: HttpRequestBuilder): HttpRequestBuilder {
val subRequest = HttpRequestBuilder().takeFrom(request)
val subRequestJob = Job(request.executionContext)
subRequest.executionContext = subRequestJob
request.executionContext.invokeOnCompletion { cause ->
val subRequestJob = subRequest.executionContext as CompletableJob
if (cause == null) subRequestJob.complete()
else subRequestJob.completeExceptionally(cause)
}
return subRequest
}

Expand Down