Use Ctypes stubgen for lp-glpk #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lp-glpk.consts exports #defined constants in glpk.h as OCaml module - lp-glpk.types uses that and build structs and enum-ish ints - We cannot use ctypes' enum function for glpk.h because there is no actual enum defs. They only use int args/fields that's assumed to take #defined values (unsafe!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (a part of) #3 by removing necessity of linking flags
-cclib -lglpkon compilation of the apps using lp-glpk.This is done by stop using dynamic ctypes.foreign and start using stub-generation feature of ctypes.
This patch also removes the hard-coding of C constants #defined in glpk.h.
Some references for stubgen features.
lp-gurobi is remained to use dynamic ctypes.foreign because build-time dependency on libgurobi (not open-source, limited access) will make some trouble.