Fix incorrect globs in Windows OS terminals (cmd, powershell) #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeJS automatically parses globs in
argv, but the actual algorithm depends on shell.Consider following example:
In WSL it will lead to
filescontaining followingWhile both in powershell and cmd
fileswill containSee nodejs/node#15529
Current logic inside
generatefunction tries parsing glob only if it's not array (in reality it's array that contains single element)