Skip to content

Fix TS2304: export LoanPaymentFrequency from auth.ts#33

Merged
kryptodrex merged 2 commits intoissue-fixesfrom
copilot/fix-build-and-test-scripts
Mar 12, 2026
Merged

Fix TS2304: export LoanPaymentFrequency from auth.ts#33
kryptodrex merged 2 commits intoissue-fixesfrom
copilot/fix-build-and-test-scripts

Conversation

Copy link

Copilot AI commented Mar 12, 2026

LoanPaymentFrequency was referenced in src/types/auth.ts (LoanPaymentLine.frequency) but only existed as a local type alias inside LoansManager.tsx, causing a hard build failure.

Summary

  • Exported LoanPaymentFrequency from src/types/auth.ts as Exclude<BillFrequency, 'custom'> — consistent with the inline Exclude already used on Loan.paymentFrequency
  • Removed the duplicate local definition in LoansManager.tsx and updated its import to pull LoanPaymentFrequency from auth.ts
// src/types/auth.ts
export type LoanPaymentFrequency = Exclude<BillFrequency, 'custom'>;

// src/components/LoansManager/LoansManager.tsx
import type { Loan, LoanPaymentFrequency, LoanPaymentLine } from '../../types/auth';
// local `type LoanPaymentFrequency = ...` removed

Type of Change

  • Bug fix

User-Facing Impact

  • This PR changes user-facing behavior
  • If user-facing behavior changed, I updated Features.md

Docs Checklist

  • I reviewed README.md and updated it for major functionality/architecture changes (if applicable)
  • I updated app_updates/APP_UPDATES.md for shipped/planned status changes (if applicable)

Validation

  • npm run lint
  • npx tsc --noEmit
  • Manual smoke test completed

Notes

  • Pure type-level change; no runtime behavior affected.

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Fix build and test scripts for issue-fixes merge Fix TS2304: export LoanPaymentFrequency from auth.ts Mar 12, 2026
@kryptodrex kryptodrex marked this pull request as ready for review March 12, 2026 15:30
@kryptodrex kryptodrex merged commit 15fbbf4 into issue-fixes Mar 12, 2026
@kryptodrex kryptodrex deleted the copilot/fix-build-and-test-scripts branch March 12, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants