Skip to content

Conversation

@tfaieta
Copy link
Contributor

@tfaieta tfaieta commented Dec 10, 2025

As mentioned this is the other option in #224:

Renaming the export key to match the file name ./generate-urls

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Rename the export key to match the actual file path (generate-urls.d.ts),
which fixes TypeScript resolution issues in certain moduleResolution
configurations and aligns with the v10.0.0 release notes documentation.

BREAKING CHANGE: Import path changed from 'universal-router/generateUrls'
to 'universal-router/generate-urls'
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (db8a409) to head (bf3c298).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #226    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         3            
  Lines          229       444   +215     
  Branches        66       133    +67     
==========================================
+ Hits           229       444   +215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frenzzy frenzzy merged commit 4a558d1 into kriasoft:main Jan 2, 2026
5 checks passed
@frenzzy
Copy link
Member

frenzzy commented Jan 2, 2026

Thank you for the fix! Sorry for the delay. Released under v10.0.2

@lazka
Copy link

lazka commented Jan 7, 2026

Could the old exports be kept maybe? This results in an API break, which is a bit unexpected for a patch release.

[RESOLVE_ERROR] Error: Could not resolve 'universal-router/generateUrls' in vendor/toolkit/packages/app-shell/src/router.js
   ╭─[ vendor/toolkit/packages/app-shell/src/router.js:2:26 ]
   
 2  import generateUrls from 'universal-router/generateUrls';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants