Skip to content

Conversation

@re-taro
Copy link
Contributor

@re-taro re-taro commented Aug 8, 2025

Description

This PR adds a package.json file to the CommonJS build output directory (cjs/) with "type": "commonjs" to properly identify the module format. This ensures that Node.js correctly treats the files in the cjs/ directory as CommonJS modules.

The build script has been updated to copy this package.json file to the distribution directory during the build process.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@re-taro
Copy link
Contributor Author

re-taro commented Aug 8, 2025

@frenzzy

This bug is pretty critical for our project, so I’d really appreciate it if you could review it with a high sense of urgency!

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (db8a409) to head (f2028c1).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #220    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         3            
  Lines          229       444   +215     
  Branches        66       133    +67     
==========================================
+ Hits           229       444   +215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frenzzy frenzzy added this to the v10.0.1 milestone Aug 8, 2025
@frenzzy frenzzy merged commit e8eaf13 into kriasoft:main Aug 8, 2025
5 checks passed
@re-taro re-taro deleted the fix/cjs-package-json branch August 8, 2025 16:58
@re-taro
Copy link
Contributor Author

re-taro commented Aug 8, 2025

Thanks!!!!!

@frenzzy
Copy link
Member

frenzzy commented Aug 8, 2025

Thank you for the fix! Released under v10.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants